Skip to content

Fix 2 embeddings-related issues in server.cpp #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Fix 2 embeddings-related issues in server.cpp #324

merged 2 commits into from
Apr 6, 2024

Conversation

k8si
Copy link
Collaborator

@k8si k8si commented Apr 5, 2024

Misc embeddings fixes:

TODO:

  • Still need to test calls to the /embeddings endpoint with a batch of texts, thus far I have only tested with single texts (will finish this on Monday)

@k8si k8si requested a review from jart April 5, 2024 22:45
@jart jart marked this pull request as ready for review April 6, 2024 06:51
Copy link
Collaborator

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix looks great. I've tested and confirmed it works locally using your script. I think this is worth merging. Please send me the tests on Monday. Then we'll close out the issue.

@jart jart merged commit 956fb58 into main Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support BERT architecture in llamafile Llama.cpp server embeddings always return a 0 filled vector.
2 participants